Disable weekly updates #1270
Merged
Disable weekly updates #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waxlamp
requested changes
Jul 13, 2022
Co-authored-by: Roni Choudhury <2903332+waxlamp@users.noreply.github.com>
marySalvi
reviewed
Jul 13, 2022
I don't think it matters as it gets into main because it will be a squash anyways, so only the changes get committed into main. So in the overall git history it will look like a single commit. If you take a look into the PR for 1.9 and activity groups getting added in there are lot of merges of main into the branch, but the history only has a single commit with the changes. It means we don't have to be exact with our development process or clean up the git history before we merge the PR, but we still retain a history of what occurred within the individual PR. There are probably good arguments for doing it the opposite as well. |
marySalvi
approved these changes
Jul 13, 2022
waxlamp
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leaves the watchtower container running but prevents it from doing the weekly update on the girder/girder-worker containers. This was request to prevent it from updating weekly like this.
https://containrrr.dev/watchtower/arguments/#filter_by_enable_label
That should provide some information on why I commented out the label in the docker-compose.yml