Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Page #1279

Merged
merged 10 commits into from
Aug 4, 2022
Merged

Admin Page #1279

merged 10 commits into from
Aug 4, 2022

Conversation

BryonLewis
Copy link
Collaborator

@BryonLewis BryonLewis commented Jul 23, 2022

This was a series of changes to include and administrator page to hopefully make life easier for us and NOAA deployments. While doing the implementation I tried to hit some of the NOAA feature requests.

  • Admin Page only visible to admins under /admin. Non admins get redirected back to their home directory. All endpoints added are guarded if necessary.
  • Added an /api/admin.service.ts file to handle some more of the admin endpoints that were generated
  • Default Recents page for Admin shows the top 50 most recent datasets uploaded including User and a link to the dataset and user Directory.
  • The Users page shows the top 50 most recent users on the system and a link to their user directory as well as their email address.
  • The Jobs page allows for easier viewing/debugging of jobs. Jobs are no submitted with the user ID and log included so it is easier to see who submitted jobs as well as providing a link to the user directory. It shows the top 50 jobs based on the filters
    • Admin jobs by default are filtered to show Inactive/Queued + Running + Errors to make it easier to debug issues
    • The user ID and a link to their directory is provided. There are also a link to the datasets as well as an actions section to be able to view the job log, cancel running/queued jobs or delete jobs outright. These actions are guarded by a prompt to confirm.
  • Addons now can be controlled through this admin page instead of the REST endpoint like before. It will automatically download the latest viame/addons.csv file and parse if for the user.
  • Brand Data can now be set using the administrator tools as well. I included the ability to change the Training Data login information and completely remove it if necessary.
  • Fixed the Queued viewing for all users, so it should report the proper number of queued items instead of the incorrect one.

Resolves #1277
Resolves #1274
Resolves #1269
Resolves #1258

@BryonLewis BryonLewis marked this pull request as ready for review July 27, 2022 13:27
@BryonLewis
Copy link
Collaborator Author

I added a fix so that the installed pipelines will now show up in the addons.

Future Additions:

  • Next Page feature for all lists instead of top 50.

client/platform/web-girder/views/Admin/AdminJobs.vue Outdated Show resolved Hide resolved
client/platform/web-girder/views/Admin/AdminRecents.vue Outdated Show resolved Hide resolved
server/dive_server/views_configuration.py Outdated Show resolved Hide resolved
client/platform/web-girder/views/Admin/UserRecents.vue Outdated Show resolved Hide resolved
@BryonLewis
Copy link
Collaborator Author

I believe I addressed all of the comments. I did some other improvements while I was in there modifying some code:

  • Added the a view button for training jobs, it will bring up a dismissable dialog with the list of datasets for that training job. I suggesting opening them with middle click in a new tab if possible
  • Updated the AdminJobs page so it updates properly when new jobs are started instead of waiting. This was mostly for the addon jobs to be visible properly.
  • I updated the text I believe where needed.

@BryonLewis BryonLewis merged commit a15a38b into main Aug 4, 2022
@BryonLewis BryonLewis deleted the add-admin-page branch August 4, 2022 14:52
BryonLewis added a commit that referenced this pull request Aug 12, 2022
* Setting up admin page

* adding more admin pages

* Adding in admin page

* fixing logic for job counting

* minor changes forgot to pushed

* Adding status to download datas

* fixing tests

* remove logo

* adding in updates

* addressing commits
BryonLewis added a commit that referenced this pull request Aug 12, 2022
* Setting up admin page

* adding more admin pages

* Adding in admin page

* fixing logic for job counting

* minor changes forgot to pushed

* Adding status to download datas

* fixing tests

* remove logo

* adding in updates

* addressing commits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants