Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upload progress indicator label #1301

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Fix upload progress indicator label #1301

merged 1 commit into from
Dec 20, 2022

Conversation

rgov
Copy link
Contributor

@rgov rgov commented Oct 14, 2022

Not 100% on this change but when uploading a zip file, the progress indicator incorrectly showed "2.13 GB of 18.91 GB remaining" with the first number counting upward, not downward — the word "remaining" was not correct.

@BryonLewis BryonLewis self-requested a review October 20, 2022 16:01
@rgov rgov closed this by deleting the head repository Nov 6, 2022
@waxlamp
Copy link
Member

waxlamp commented Dec 19, 2022

Hi @rgov. Sorry it took us so long to get back to you on this.

I see that you closed your PR. Do you believe it's no longer relevant?

@rgov
Copy link
Contributor Author

rgov commented Dec 19, 2022

Oh I probably was just cleaning up forks and didn't realize this one had an outstanding pull request.

@rgov rgov reopened this Dec 19, 2022
Copy link
Collaborator

@marySalvi marySalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@marySalvi marySalvi merged commit bb7797b into Kitware:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants