Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dockerfile #26

Closed
wants to merge 1 commit into from
Closed

Fix Dockerfile #26

wants to merge 1 commit into from

Conversation

jorgensd
Copy link

@jorgensd jorgensd commented Jan 30, 2021 •
edited

The current Dockerfile produces the following error:

An error occured.
ValueError: Please install nodejs >=12.0.0 before continuing. nodejs may be installed using conda or directly from the nodejs website.

Can also be reproduced by running the Binder-link:https://mybinder.org/v2/gh/Kitware/ipyvtk-simple/master
This PR fixes this by getting the latest nodejs with wget.

@jorgensd jorgensd mentioned this pull request Jan 30, 2021
Closed
banesullivan
banesullivan approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@banesullivan banesullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this adjustment! I have had troubles with conda installing too old of a nodejs version (10.x usually)

@banesullivan banesullivan mentioned this pull request Feb 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banesullivan banesullivan banesullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jorgensd @banesullivan