-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(toMultiscaleChunkedImage): Support passing a Zarr store #391
Conversation
Hi @thewtex This is awesome, I am testing it now. I noticed that you have these lines in the const zattrs = await store.getItem('.zattrs')
const multiscales = zattrs.multiscales
const name = multiscales[0]['name']
const datasets = multiscales[0].datasets Are you assuming the |
Yes, a json object or an arraybuffer.
This makes things more complex and adds unnecessary conversions, correct? Why force JSON data into an ArrayBuffer? And then convert it back? With Zarr, we know that some keys are always JSON and some are always ArrayBuffer's. |
While it seems to add unnecessary overhead, I'll change the behavior to be consistent with the Zarr Python spec and behavior, which is always using |
Yes, I agree that will be some overhead, but perhaps it doesn't matter that much because those are mostly for meta information which often very small. I was about to say the same, since the Zarr store in Python also return bytes. |
JSON Zarr members are also returned as ArrayBuffer's from the store, in line wit the Zarr spec.
@oeway thanks for the review and suggestion. All ArrayBuffer values is now implemented. Please take a look. |
Hey, thanks a lot! Super exciting to try it! The PR looks good! I just trie to test it but don't have the right data format yet. |
Thanks! With the foundation down, I'll continue with the other store implementations :-) |
🎉 This PR is included in version 11.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.