Remove points

[danlipsa]

No description provided.

[danlipsa]

Needs Kitware/fletch#699

[danlipsa]

@mleotta Please review. How do I get a user name for Jenkins to see the issue with the linux build?

[mleotta]

I think the linux CI machine might just be down. I'm seeing a similar failure on other PRs. @dstoup or @Cookt2 can you confirm?

[kwcvrobot]

Kwiver Windows build succeeded.

[kwcvrobot]

Kwiver Windows build succeeded.

[kwcvrobot]

Kwiver Windows build succeeded.

[kwcvrobot]

Kwiver Windows build succeeded.

[mleotta]

jenkins test this please

[kwcvrobot]

Kwiver Windows build succeeded.

[kwcvrobot]

Kwiver Windows build succeeded.

[mleotta]

@danlipsa this is failing because VTK 9.1 is not the default on the CI machines. Either I need to get consensus to make it the default or we need to conditionally disable these new features if building with older VTK.

[danlipsa]

I see. Yes, the filter I use is not available for VTK < 9.1

[mleotta]

It seems that we need to update this file:
https://github.com/Kitware/kwiver/blob/master/CMake/kwiver-depends-VTK.cmake
to enforce that KWIVER requires at least VTK 9.1. Currently we can build against > 8.0.

The alternative is to find away to disable the new features you added when using older VTK or to use an alternate implementation that does not need VTK 9.1.

[danlipsa]

@mleotta Are the CIs updated?

[danlipsa]

jenkins test this please

[danlipsa]

@mleotta So now I compile color_mesh only if we have VTK >= 9.1. This way we keep visgui working for older versions of VTK. Would that work?

[kwcvrobot]

Kwiver Windows build succeeded.

[mleotta]

See inline comments.

I think disabling color-mesh for older VTK is a reasonable compromise. Disabling only the use of vtkRemovePolyData within color-mesh would be better, but also a lot messier.

[kwcvrobot]

Kwiver Windows build succeeded.

[chetnieter]

Jenkins test this please

[chetnieter]

All the build failures say 'Build step 'Execute shell' marked build as failure' at the very end despite the build succeeding and the tests passing.

[mleotta]

Jenkins test this please

[kwcvrobot]

Kwiver Linux build succeeded.

[kwcvrobot]

Kwiver CentOS build succeeded.

[kwcvrobot]

Kwiver Mac build succeeded.

[kwcvrobot]

Kwiver Windows build succeeded.

[chetnieter]

@mleotta Tests passed so I assume we are ok to merge?