Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add example tracking support #361

Closed
wants to merge 4 commits into from

Conversation

linus-sherrill
Copy link
Collaborator

Adding example - skeletal tracker support by moving basic classes from other topic branches.

Add PLUGIN_ORGANIZATION as needed.
Added:
- abstract algorithm
- concrete algorithm
- process
Added:
- abstract algorithms
- concrete implementations for reading in kw18 format
- reader and writer processes
Added abstract algorithm
Added concrete implementation
Added type and port trait for track association score
@kwcvrobot
Copy link
Collaborator

Linux build failure: https://open.cdash.org/buildSummary.php?buildid=5127959

@mattdawkins
Copy link
Member

I would prefer you don't submit this. You cherry-picked a majority of the other tracking branch. It could possibly mess up the git history of other branches that tracking branch has been merged into.

@collinsr
Copy link
Member

collinsr commented Nov 3, 2017

We'll never just land that branch in one go; we can't land a megabranch (with all of the inertia associated with its code mass) and defer refactoring until a hypothetical point in the future when enough energy has been gathered to overcome that inertia. IMHO it's better to take it step by step.

@kwcvrobot
Copy link
Collaborator

@kwcvrobot
Copy link
Collaborator

Windows build failure: https://open.cdash.org/buildSummary.php?buildid=5128028

@mattdawkins
Copy link
Member

This branch has 68% of the mass of the other one and as far as I can tell duplicated functionality. Where do you draw the line on what is considered a "megabranch"? 👎

@linus-sherrill linus-sherrill deleted the dev/add-example-tracking-support branch October 6, 2020 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants