Add timeout to Google Test discovery #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweak Google Test discovery to abort if the test executable fails to complete within 30 seconds. This is a work-around for the thread_pool test which is currently hanging on our Windows dashboard build for reasons not-yet-known. (Curiously, it only hangs when given --gtest_list_tests; when the tests actually run, they pass, and the executable exits normally.) This is not currently upstream, but I intend to submit a version of this for inclusion in CMake 3.10.1.
|
Linux build succeeded: https://open.cdash.org/buildSummary.php?buildid=5158335 |
|
Windows build failure: https://open.cdash.org/buildSummary.php?buildid=5158235 |
|
(Note: This feature has been proposed for upstream inclusion as !1534.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak Google Test discovery to abort if the test executable fails to complete within 30 seconds. This is a work-around for the
thread_pooltest which is currently hanging on our Windows dashboard build for reasons not-yet-known. (Curiously, it only hangs when given--gtest_list_tests; when the tests actually run, they pass, and the executable exits normally.)This is not currently upstream, but I intend to submit a version of this for inclusion in CMake 3.10.1.