Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix breaks compatability with Python 3.8 #64

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Fix breaks compatability with Python 3.8 #64

merged 3 commits into from
Feb 15, 2024

Conversation

tkoyama010
Copy link
Contributor

resolves #63

@tkoyama010 tkoyama010 mentioned this pull request Feb 15, 2024
Closed
@jourdain
Copy link
Collaborator

To fix the precommit fix you need to have your commit like fix(py3.8): ensure compatibility across py version

@jourdain
Copy link
Collaborator

Otherwise it won't trigger a release

@jourdain jourdain merged commit 36a58c1 into Kitware:master Feb 15, 2024
3 checks passed
@tkoyama010 tkoyama010 deleted the patch-1 branch February 15, 2024 19:58
@tkoyama010
Copy link
Contributor Author

Thanks for fixing the commit message.

@MattTheCuber
Copy link
Contributor

Just FYI, SHA1 has similar performance to MD5 and is FIPS compliant (140-2, not 140-3). Might be a better alternative for Python<=3.9

@jourdain
Copy link
Collaborator

no worries with the squash option it was easy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2.8.4 breaks compatability with Python 3.8
3 participants
@tkoyama010 @jourdain @MattTheCuber