fix(remote rendering): round view size #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yes please. Thx that seems reasonable. |
|
will do asap. |
bourdaisj
force-pushed
the
round-view-size-instead-of-int-conversion
branch
from
a0dd18b
to
dfb0487
Compare
comply with vue-vtk-js vtkRemoteView implementation which uses Math.round for setting view size. python builtin round function does not work the same way: it rounds half to even.
bourdaisj
force-pushed
the
round-view-size-instead-of-int-conversion
branch
from
dfb0487
to
0a72916
Compare
|
@jourdain please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like
vue-vtk-jsusesMath.roundfor the view size. For instance: https://github.com/Kitware/vue-vtk-js/blob/master/src/core/VtkRemoteView.js#L218So it seems like I went into issues with the view size on the server not matching the view size on the browser, which could trigger an infinite loop in
vue-vtk-js, requesting an new render then throwing it away over and over again: https://github.com/Kitware/vue-vtk-js/blob/master/src/core/VtkRemoteView.js#L234The fix proposed here is to update the paraview protocol to comply with vue-vtk-js vtkRemoteView implementation which uses Math.round for setting view size. I used it for a few days and my problem did not ever happen again.
How does that look? @jourdain
Should I update the VTK protocol the same way?