Potential typo in Utilities/ParaView/export-scene-macro.py

[dasmy]

I assume, this file is deprecated. However, while trying to learn from the code, I came across the line

vtk-js/Utilities/ParaView/export-scene-macro.py

Line 244 in 6ae17f8

cd_size = pd.GetNumberOfArrays()

.

Shouldn't it be cd.GetNumberOfArrays() instead of pd.GetNumberOfArrays()?

[patrickoleary]

Shouldn't it be cd.GetNumberOfArrays() instead of pd.GetNumberOfArrays()?

…

On Wed, Jun 29, 2022 at 2:29 PM Mathias Winkel ***@***.***> wrote: I assume, this file is deprecated. However, while trying to learn from the code, I came across the line https://github.com/Kitware/vtk-js/blob/6ae17f80c8496191d5439eaf746eac772a40450b/Utilities/ParaView/export-scene-macro.py#L244 . Shouldn't it be cd.GetNumberOfArrays() instead of cd.GetNumberOfArrays()? — Reply to this email directly, view it on GitHub <#2499>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYGDMOSQUSNX32JZIRQSNTVRS53HANCNFSM52HF5UWQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[dasmy]

Shouldn't it be cd.GetNumberOfArrays() instead of pd.GetNumberOfArrays()?
…

Opps, fixed my typo. Thanks :-)

[finetjul]

Hi dasmy, I think you are right. can you please submit a PR ?

[dasmy]

Hi @finetjul,
As I needed some more fixes / additions to the macro (see https://discourse.paraview.org/t/trouble-exporting-scene-to-vtkjs/9829/10 for the full story), I did several additional modifications, see https://github.com/dasmy/export-scene-macro .

Does it make sense to discuss them and create a composite PR or should I for now only address the change mentioned above?

[DavidBerger98]

Hi @dasmy,

Thank you for opening this issue and suggested changes.

You can create one PR with your changes from the discussion and the fixed typo. Linking the discourse thread and this issue in the PR should be enough.

I am pinging @jourdain in case he wants to add anything to the discussion.

Best,

David

[jourdain]

I'm good pushing that macro forward. In general. It is a "deprecated path" now that we have a more mainstream C++ one. But it is definitely an easier path for the community to contribute and extend it to better fit their needs.

[github-actions]

🎉 This issue has been resolved in version 25.2.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀