feat(XMLReader): read in string arrays #2864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix zlib data parsing by finding the first zlib magic byte. - Refactor out common logic between processDataArray and processStringArray.
floryst
force-pushed
the
read-string-arrays
branch
from
dabf0d5
to
08d93dd
Compare
|
🎉 This PR is included in version 28.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
XMLReader doesn't process field data and doesn't support reading in string arrays.
Results
XMLReader now supports field data and handling of string arrays.
Changes
processStringArray.
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting