Fix vtkImageSlice typescript definitions #2896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadh4v
force-pushed
the
fix-ImageResliceMapper-ImageSlice-typescript-defs
branch
from
03311c9
to
32301a4
Compare
floryst
reviewed
Aug 22, 2023
jadh4v
force-pushed
the
fix-ImageResliceMapper-ImageSlice-typescript-defs
branch
3 times, most recently
from
9f36aac
to
cc211cd
Compare
Fix typescript definition error when using vtkImageResliceMapper with vtkImageSlice. Change vtkImageSlice to accept vtkAbstractImageMapper. Fixes errors such as: ``` Argument of type 'vtkImageResliceMapper' is not assignable to parameter of type 'vtkImageMapper'. Type 'vtkImageResliceMapper' is missing the following properties from type 'vtkImageMapper': getSliceAtPosition, getClosestIJKAxis, getBoundsForSlice, getRenderToRectangle, and 15 more. ```
jadh4v
force-pushed
the
fix-ImageResliceMapper-ImageSlice-typescript-defs
branch
from
cc211cd
to
18356b4
Compare
floryst
approved these changes
Aug 23, 2023
|
🎉 This PR is included in version 28.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue: #2878
Fix typescript definition error when using
vtkImageResliceMapperwithvtkImageSlice. ChangevtkImageSliceto acceptvtkAbstractImageMapperwhen callingsetMapper.Fixes errors such as:
Context
Results
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting
This change adds or fixes unit tests