Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: drop DistanceWidget #2945

Merged
merged 1 commit into from
Oct 26, 2023
Merged

refactor: drop DistanceWidget #2945

merged 1 commit into from
Oct 26, 2023

Conversation

floryst
Copy link
Collaborator

@floryst floryst commented Oct 26, 2023 •
edited
Loading

Context

#2891

Results

LineWidget is favored over the distance widget.

Changes

  • distance widget is now removed

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

@floryst
refactor: drop DistanceWidget
ecc274d 
BREAKING CHANGE: LineWidget is favored over the distance widget.
@floryst floryst changed the base branch from master to v29-merge October 26, 2023 15:54
@floryst floryst added this to the v29 milestone Oct 26, 2023
@floryst floryst merged commit 20986be into v29-merge Oct 26, 2023
4 checks passed
@floryst floryst deleted the drop-distancewidget branch October 26, 2023 17:05
finetjul
finetjul reviewed Oct 26, 2023
View reviewed changes
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finetjul finetjul finetjul left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v29
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@floryst @finetjul