feat(reslicecursor): expose a convenient getPlaneExtremities function #2980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finetjul
force-pushed
the
reslicecursorwidget-add-sliders
branch
from
6fa6d80
to
1d3594e
Compare
floryst
reviewed
Jan 8, 2024
This is useful to control the center using sliders.
finetjul
force-pushed
the
reslicecursorwidget-add-sliders
branch
from
1d3594e
to
8454ca8
Compare
bruyeret
reviewed
Jan 8, 2024
| [] | ||
| ); | ||
| // FIXME: support oriented bounds | ||
| const intersectionPoints = vtkBox.intersectWithLine( |
There was a problem hiding this comment.
An idea of solution:
From the image direction, we already have the 3 normals of the 6 planes of the image oriented bounding box.
Now let's say we have for each plane i the equation X.N_i = a_i (the equation of a plane, we get a_i using indexToWorld)
And the equation of the line X = b * N
Then the intersection of the plane i and the line verifies: (b * N). N_i = a_i so b = a / (N.N_i) when N.N_i is not 0.
We get 6 different values for b and only keep the biggest negative and the smallest positive (if there is a negative and a positive value).
From b, we get the point by doing X = b * N.
bruyeret
approved these changes
Jan 8, 2024
|
🎉 This PR is included in version 29.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful to control the center using sliders.
Context
It is not obvious how to control the reslice cursor widget with sliders.
Results
This PR demonstrates how to control the reslice cursor widget with sliders and expose a convient function.
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting