feat(filter): Add contour loop extraction filter #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Forrest Li <forrest.li@kitware.com>
floryst
reviewed
Jan 31, 2024
floryst
reviewed
Feb 7, 2024
| const outLines = output.getLines(); | ||
| outLines.resize(0); | ||
|
|
||
| // Optional merging of contours can happen here |
There was a problem hiding this comment.
We can drop this comment, since it's not implemented.
|
@floryst Would it be possible for you to re-review this? |
|
LGTM! Thanks! |
|
🎉 This PR is included in version 29.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
contourLoopExtractioncode, I am just providing an example, as well as typing and submitting a pull request.This PR introduces the
vtkContourLoopExtractionfilter, which is designed to extract closed loop contours from the output of the vtkPolyData.Unlike tools like
vtkCutter, which lack sufficient clustering information about the cuts,vtkContourLoopExtractionefficiently traverses the points to identify loops.Results
I've included an example that demonstrates this amazing feature. In this particular example, we obtain the output of the
vtkCutterand then pass it to thevtkContourLoopExtraction. Finally, we generate separate polyData for each individual contour, with each contour having its own unique color.vtk.mp4
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting