Add custom color mix functions for volume mapper fragment shader #3029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using independent components, and the first component was proportional, tColor.a was multiplied by pwfValue because of the line `tColor *= pwfValue;`. To avoid this kind of errors and make the code clearer, use a separte `vec3 tColor` and a `float alpha`.
Only one minor change to the logic: Enable complex lighting of dependent component rendering even when there is more than 1 component To disable it, set vtlLightComplexity to 0
The mixing of independent components is now done in function This function is very likely inlined by the compiler, it should not hurt performance Create the UseIndependentComponents preprocessor macro
Add an ADDITING preset
Move custom code computation to the volume property
|
Just need to add a preset for |
finetjul
reviewed
Mar 6, 2024
sankhesh
reviewed
Mar 6, 2024
| applyLighting(tColor0, normal0); | ||
| applyLighting(tColor1, normal1); | ||
| #endif | ||
| vec3 mixedColor = mix(tColor0, tColor1, opacity1 / opacitySum); |
There was a problem hiding this comment.
Maybe I'm not understanding the big picture here.
How is this different from the current code where independent components are alpha-blended?
Secondly, this is not doing an additive blend, is it?
There was a problem hiding this comment.
If we have alphas a0 and a1, and colors c0 and c1, then:
With alpha blending:
color = (c0 * a0 + (1 - a0) * c1 * a1 ) / alpha
alpha = a0 + (1 - a0) * a1
With additive mode:
color = (c0 * a0 + c1 * a1) / alpha
alpha = a0 + a1
Also how to create alpha blending with independent components in the current shader?
Do you suggest a different name instead or additive mode ?
finetjul
reviewed
Mar 7, 2024
This makes using user defined shader replacements possible The renderPass shader replacements are not implemented
finetjul
reviewed
Mar 7, 2024
Move the api specific code completely out of the VolumeProperty class
Add some documentation in the typescript header Make the GLSL code clearer
Makes the code a lot clearer and more flexible to be able to use it in colorMixPresets
|
🎉 This PR is included in version 29.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom shader code is used to merge blend components
Presets can be used, I added an
ADDITINGpreset that is useful when using medical images with labelsAlso added a test with 2 baselines