Crop widget v2 #745
Merged
Crop widget v2 #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trigger general geometry updates whenever state is updated.
Handles should resize to be relative to the viewport and not the scene.
|
Still using the cellPicker? |
|
Yeah, still using cell picker for these, since I have actual actors for each handle. Haven't worked on a widget that properly handles multiple handles yet. |
|
Looks awesome! I like the corner controls.
…On Thu, May 31, 2018 at 1:51 PM Forrest Li ***@***.***> wrote:
Yeah, still using cell picker for these, since I have actual actors for
each handle. Haven't worked on a widget that properly handles multiple
handles yet.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#745 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AARErzRgv1gn_eZpI_09lO5CCE2pfKX_ks5t4C2NgaJpZM4UVc8L>
.
--
====================================================
Stephen R. Aylward, Ph.D.
Senior Director of Strategic Initiatives, Kitware, Inc., North Carolina
http://www.kitware.com and http://www.aylward.org
(919) 969-6990 x300
====================================================
|
If the underlying data is cropped, we don't want to use updated transforms because the origin will change.
|
🎉 This PR is included in version 6.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This iteration of the crop widget provides a means of manipulating a box in 3D space. Cropping planes are exported out via an event or via
widget.getCroppingPlanes(). This is a first pass.There are three sets of control handles: face handles, edge handles, and corner handles.
A small demo is shown below with face and corner handles.
@jourdain @martinken @wschroed @aylward