Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add wasm configuration #115

Merged
merged 2 commits into from Feb 15, 2024
Merged

ENH: Add wasm configuration #115

merged 2 commits into from Feb 15, 2024

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Feb 15, 2024

Build javascript, typescript, cli, packages, documentation via ITK-Wasm.

A few tests added for the CLI, javascript, typescript to ensure they run. Other testing is left to the module.

CI for build/test of everything and build / deploy of the documentation to GitHub Pages.

Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions and remarks in-line.

.github/workflows/documentation.yml Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
wasm/test/data/input/64816L_amygdala_int.nii.gz Outdated Show resolved Hide resolved
Build javascript, typescript, cli, packages, documentation via ITK-Wasm.

A few tests added for the CLI, javascript, typescript to ensure they
run. Other testing is left to the module.

CI for build/test of everything and build / deploy of the documentation
to GitHub Pages.
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after getting CI green.

@thewtex
Copy link
Member Author

thewtex commented Feb 15, 2024

Wasm build/test runs and is green! 🎉 💚

Native Python failures are unrelated.

@thewtex thewtex merged commit e2c9c64 into KitwareMedical:master Feb 15, 2024
12 of 16 checks passed
@thewtex thewtex deleted the wasm branch February 15, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants