G3log placeholder thread ID formatting #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
KjellKod
commented
Mar 2, 2018
•
KjellKod
commented
- Enable custom formattting of log entries.
- See also g3sinks enabling of this feature G3log placeholder thread ID formatting g3sinks#53
- See also updated API.markdownt](https://github.com/KjellKod/g3log/blob/g3log-placeholder-threadid-formatting/API.markdown)
added 3 commits
February 22, 2018 23:54
…ocumentation and some corner test cases for CHECK, LOG(FATAL) and FATAL signal
bmagistro
reviewed
Mar 3, 2018
API.markdown
Outdated
| ### Adding thread ID to the log formatting | ||
| An "all details" log formatting function is also defined - this one also adds the "calling thread's ID" | ||
| ``` | ||
| static std::string DefaultLogDetailsToString(const LogMessage& msg); |
There was a problem hiding this comment.
Believe this should be FullLogDetailsToString(...)
There was a problem hiding this comment.
Thanks. I’ll go over the doc changes and clear things up
|
@bmagistro let me know how testing goes. Otherwise I'll go ahead and merge this later this week. |
|
Things have gone well, haven't seen any issues, many thanks for getting this added! |
|
I guess this is coming in the 1.4 release? |
|
Yes. But I’m waiting with making a release until its collected enough content.
It is already available in the master branch
…Sent from my iPhone
On Aug 15, 2018, at 23:20, T.J. Mercier ***@***.***> wrote:
I guess this is coming in the 1.4 release?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.