Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for iOS and MacOS build #1

Merged
merged 21 commits into from
Feb 10, 2015
Merged

Conversation

um68
Copy link
Collaborator

@um68 um68 commented Feb 9, 2015

Most libs build now for iOS and MacOS
bru has new command line option to specify the targetPlatform which is required to build for iOS (by default, it would build for MacOS if run on MacOS).

@KjellSchubert
Copy link
Owner

Note the Travis build failed with:

======================================================================
ERROR: tests 'bru install zlib', which is one of the simplest cases
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/KjellSchubert/bru/tests/test_install.py", line 171, in test_install_zlib
    install.cmd_install(library, ['zlib'])
TypeError: cmd_install() takes exactly 3 arguments (2 given)
======================================================================
ERROR: test_make_tinyjs (test_make.MakeTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/KjellSchubert/bru/tests/test_make.py", line 26, in test_make_tinyjs
    brulib.install.cmd_install(library, ['tiny-js'])
TypeError: cmd_install() takes exactly 3 arguments (2 given)

So you added an arg to some script func. Easiest would be to make this arg an optional Python arg (http://stackoverflow.com/questions/1769403/understanding-kwargs-in-python), alternatively update the tests using the modified func.

@coveralls
Copy link

Coverage Status

Coverage decreased (-12.01%) to 67.82% when pulling 45e8a57 on um68:master into 50a21c9 on KjellSchubert:master.

KjellSchubert added a commit that referenced this pull request Feb 10, 2015
Update for iOS and MacOS build
@KjellSchubert KjellSchubert merged commit 9f974f8 into KjellSchubert:master Feb 10, 2015
um68 added a commit that referenced this pull request Feb 12, 2015
updated to latest from main
um68 pushed a commit that referenced this pull request Sep 2, 2015
um68 added a commit that referenced this pull request Sep 2, 2015
Merge pull request #1 from KjellSchubert/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants