enhanced terminal tracking/Pid input #1
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies in advance for a slightly
monolithic
pull request. I had submitted this pull request to the main vim-slime repo, and the feedback I got was to write an extension forvim-slime-ext-plugins
. At the time I didn't have the bandwidth to go through the code and figure out how to do that. I saw your extension and the code you wrote gave me the base knowledge to figure out how slime-ext-plugins works. The two main features that I ad areEnhanced tracking of terminals. Using autocommands in a file in the
plugin
directory`, PID and internal Neovim job ids are kept track of in a stack of dictionaries. Users are always prompted to use the terminal on top of the stack, and terminal info is popped off when the terminal is closed.Being prompted with PID number to select a terminal rather than the Neovim job id. This is better because the PID is visible in the status line of the terminal.
I've written an excessively verbose README. This is because I always appreciate it when documentation is written at a level where a novice can understand.
I'm being slightly presumptuous here, and this would completely be based on your preference, but instead of completing this pull request I could make a pull request on the main vim -slime-ext-plugins repo to link to my fork.