Status override #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext-neovim into windows_compatibility
clarified something
updated readme further
|
Thanks, I'm a bit busy right now, but I'll review and merge this week-end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I think it should be stable for now.
Did a quick test on windows and it works there too. Not sure how windows keeps track of
pidbut terminal buffers on windows in neovim have both a job id and a pid, though I'm not sure what the latter refers to on a windows system. \There is a native function that converts job id to pid so I used that instead of my own function
Important: there is now an option to override the default status bar of the neovim terminal so that it shows both the job id and pid in the bottom right. There is also an option to show cursor position information like when
ruleris set. There are many ways that we could let the user customize the status bar of the terminal, but I think these options are adequate for now.Used panvimdoc to generate documentation from the readme. Could have done this as a workflow, but instead manually ran the script.