Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off autoComplete in the AutoComplete component #1429

Closed
eheslouisKlee opened this issue Jul 28, 2017 · 3 comments
Closed

Turn off autoComplete in the AutoComplete component #1429

eheslouisKlee opened this issue Jul 28, 2017 · 3 comments

Comments

@eheslouisKlee
Copy link

Current behaviour

The Autocomplete allows the navigator's autocomplete which doesn't return the code and is confusing for the user.

Expected behaviour

The attribute 'autoComplete="off"' should be added by default to the composent so that the only clickable options come from the focus composent.

Versions

Focus-core: lastest
Focus-components: lastest

@Hartorn Hartorn self-assigned this Jul 31, 2017
@Hartorn Hartorn added this to the 2.2.0 milestone Jul 31, 2017
@Hartorn Hartorn added the Bug label Jul 31, 2017
@Hartorn Hartorn assigned Hartorn and bnau and unassigned Hartorn Jul 31, 2017
@Hartorn
Copy link
Contributor

Hartorn commented Jul 31, 2017

@bnau Small issue to begin with.
Basically, it is adding a props on the input, so web navigator do not output an autocomplete.
See https://developer.mozilla.org/fr/docs/Web/HTML/Element/Input#attr-autocomplete for detail.

Be wary of React "camelcasing" attribute on html element.

@bnau
Copy link
Contributor

bnau commented Sep 25, 2017

Pull request #1461

@Hartorn
Copy link
Contributor

Hartorn commented Nov 15, 2017

Delivered in 2.2.0

@Hartorn Hartorn closed this as completed Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants