Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Remove Handcrafted Types from carbonmark.types.ts #2293

Open
0xemc opened this issue Feb 19, 2024 · 0 comments
Open

[refactor] Remove Handcrafted Types from carbonmark.types.ts #2293

0xemc opened this issue Feb 19, 2024 · 0 comments

Comments

@0xemc
Copy link
Collaborator

0xemc commented Feb 19, 2024

Subject: Code Refactoring - Removal of Handcrafted Pool and Project Types

See:

#2276 (comment)

Details:
Within carbonmark.types.ts, the Pool and Project types are currently defined manually. These types should be refactored to either use auto-generated types from our GraphQL schema or to better align with the project's type generation strategy.

Expected Outcome:

  • Handcrafted Pool and Project types in carbonmark.types.ts are removed.
  • Replacement of the types with auto-generated or strategically aligned types.
  • Ensuring that the new types integrate seamlessly with the existing codebase.
  • No type errors in the build, and all associated functionality is tested to be working as expected.

Testing:

  • Ensure the build passes without type errors.
  • Run all unit and integration tests to confirm that related functionalities are unaffected by the type changes.
  • Manual testing of the affected areas to verify that there are no regressions.

Labels:
refactor

@0xemc 0xemc added the refactor label Feb 19, 2024
@jabby09 jabby09 changed the title Refactor: Remove Handcrafted Types from carbonmark.types.ts [refactor] Remove Handcrafted Types from carbonmark.types.ts Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants