You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Details:
Within carbonmark.types.ts, the Pool and Project types are currently defined manually. These types should be refactored to either use auto-generated types from our GraphQL schema or to better align with the project's type generation strategy.
Expected Outcome:
Handcrafted Pool and Project types in carbonmark.types.ts are removed.
Replacement of the types with auto-generated or strategically aligned types.
Ensuring that the new types integrate seamlessly with the existing codebase.
No type errors in the build, and all associated functionality is tested to be working as expected.
Testing:
Ensure the build passes without type errors.
Run all unit and integration tests to confirm that related functionalities are unaffected by the type changes.
Manual testing of the affected areas to verify that there are no regressions.
Labels:
refactor
The text was updated successfully, but these errors were encountered:
jabby09
changed the title
Refactor: Remove Handcrafted Types from carbonmark.types.ts
[refactor] Remove Handcrafted Types from carbonmark.types.ts
Feb 20, 2024
Subject: Code Refactoring - Removal of Handcrafted
Pool
andProject
TypesSee:
#2276 (comment)
Details:
Within
carbonmark.types.ts
, thePool
andProject
types are currently defined manually. These types should be refactored to either use auto-generated types from our GraphQL schema or to better align with the project's type generation strategy.Expected Outcome:
Pool
andProject
types incarbonmark.types.ts
are removed.Testing:
Labels:
refactor
The text was updated successfully, but these errors were encountered: