Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emc/hotfix/1395 Type generation for Sanity in Carbonmark API #1397

Merged
merged 34 commits into from
Aug 31, 2023
Merged

Emc/hotfix/1395 Type generation for Sanity in Carbonmark API #1397

merged 34 commits into from
Aug 31, 2023

Conversation

0xemc
Copy link
Collaborator

@0xemc 0xemc commented Aug 3, 2023 •
edited
Loading

Description

An issue occurred recently when the wrong order of arguments was applied to a function that fetched from Sanity.

This PR:

  • Removes SanityClient
  • Uses the sanity graphql endpoint deployed via deploy-graphql in the carbon-projects repo
  • Generates types from the above schema
  • Generates fetch (sdk) utilities to ensure that correct arguments are supplied when fetching for projects

Related Ticket

Resolves #1395

@0xemc 0xemc had a problem deploying to Preview – carbonmark-api August 3, 2023 08:02 — with GitHub Actions Failure
@vercel
Copy link

vercel bot commented Aug 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbonmark ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 11:23pm
carbonmark-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 11:23pm
demo-integration ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 11:23pm
klimadao-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 11:23pm
klimadao-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 11:23pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
carbonmark-data ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2023 11:23pm

@0xemc 0xemc had a problem deploying to Preview – carbonmark-api August 3, 2023 08:27 — with GitHub Actions Failure
@0xemc 0xemc had a problem deploying to Preview – carbonmark-api August 3, 2023 08:28 — with GitHub Actions Failure
@0xemc 0xemc temporarily deployed to Preview – carbonmark-api August 3, 2023 08:30 — with GitHub Actions Inactive
@0xemc 0xemc temporarily deployed to Preview – carbonmark-api August 4, 2023 00:51 — with GitHub Actions Inactive
@0xemc 0xemc temporarily deployed to Preview – carbonmark-api August 4, 2023 00:59 — with GitHub Actions Inactive
@0xemc 0xemc temporarily deployed to Preview – carbonmark-api August 30, 2023 22:13 — with GitHub Actions Inactive
@0xemc 0xemc temporarily deployed to Preview – carbonmark-api August 30, 2023 22:18 — with GitHub Actions Inactive
@0xemc 0xemc temporarily deployed to Preview – carbonmark-api August 30, 2023 23:19 — with GitHub Actions Inactive
@Atmosfearful Atmosfearful merged commit 1a7c601 into staging Aug 31, 2023
10 checks passed
@Atmosfearful Atmosfearful deleted the emc/hotfix/1395-cleanup-cmsdata-in-get-projects branch August 31, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atmosfearful Atmosfearful Atmosfearful approved these changes

@0xMakka 0xMakka Awaiting requested review from 0xMakka

@sprrwhwk sprrwhwk Awaiting requested review from sprrwhwk

Assignees
No one assigned
Labels
None yet
Projects
Sprint Planning
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Descriptions from GET /projects
2 participants
@0xemc @Atmosfearful