Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emc/feature/carbonmark map view #1408

Merged
merged 47 commits into from
Aug 30, 2023
Merged

Conversation

0xemc
Copy link
Collaborator

@0xemc 0xemc commented Aug 9, 2023

Description

Speaking with @Atmosfearful recently, we decided that Carbonmark could benefit from a Map View so here it is:

Note: the button styling and overlay issues in the video are resolved in the newest version

output.mp4

Remaining:

@0xemc 0xemc temporarily deployed to Preview – carbonmark-api August 9, 2023 22:59 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Aug 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbonmark ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 9:47pm
carbonmark-api ✅ Ready (Inspect) Visit Preview Aug 29, 2023 9:47pm
demo-integration ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 9:47pm
klimadao-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 9:47pm
klimadao-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 9:47pm

@jabby09
Copy link
Member

jabby09 commented Aug 28, 2023

This is unfortunately showing the various vintages for that project. Until we can think of a neat way of showing this I've hidden extra vintages (we should tackle this in a seperate ticket)

@0xemc sounds good. This will likely resolve itself in v2 of the project pages where we will only have one project and the vintages will be listings on the project (i.e. so not a separate project by vintage)

Copy link
Member

@jabby09 jabby09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xemc I saw your comments on my other feedback and all good

One other thing, need to maintain the hover tool tips on these view options...
Screenshot 2023-08-28 at 4 49 58 PM

So for example:
Screenshot 2023-08-28 at 4 50 23 PM

@0xemc 0xemc temporarily deployed to Preview – carbonmark-api August 29, 2023 06:53 — with GitHub Actions Inactive
@0xemc
Copy link
Collaborator Author

0xemc commented Aug 29, 2023

@0xemc I saw your comments on my other feedback and all good

One other thing, need to maintain the hover tool tips on these view options... Screenshot 2023-08-28 at 4 49 58 PM

So for example: Screenshot 2023-08-28 at 4 50 23 PM

Good pickup, updated 👍

Copy link
Member

@jabby09 jabby09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@0xemc 0xemc merged commit 5932259 into staging Aug 30, 2023
9 checks passed
@0xemc 0xemc deleted the emc/feature/carbonmark-map-view branch August 30, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants