Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include address field in firestore on user profile creation #1451

Merged

Conversation

psparacino
Copy link
Collaborator

@psparacino psparacino commented Aug 18, 2023

Description

To reflect the firestore updates, the address field needs to be added to the firestore docs on user profile creation.

NOTE: I could not run build-all due to build errors in site/, but I ran build-carbonmark-api successfully

Checklist

  • I have run npm run build-all without errors
  • I have formatted JS and TS files with npm run format-all

@psparacino psparacino temporarily deployed to Preview – carbonmark-api August 18, 2023 20:14 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Aug 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbonmark ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2023 6:59am
carbonmark-api ✅ Ready (Inspect) Visit Preview Aug 28, 2023 6:59am
demo-integration ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2023 6:59am
klimadao-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2023 6:59am
klimadao-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2023 6:59am

Copy link
Collaborator

@0xemc 0xemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 👍

@Atmosfearful Atmosfearful merged commit bfa582e into staging Aug 31, 2023
9 checks passed
@Atmosfearful Atmosfearful deleted the tufnel/include-address-field-on-user-profile-creation branch August 31, 2023 18:59
@biwano biwano mentioned this pull request Sep 8, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants