Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement digital carbon page #1599

Merged
merged 1 commit into from
Oct 2, 2023
Merged

implement digital carbon page #1599

merged 1 commit into from
Oct 2, 2023

Conversation

sprrwhwk
Copy link
Member

@sprrwhwk sprrwhwk commented Sep 28, 2023

Description

Related Ticket

Resolves #1590

Checklist

  • I have run npm run build-all without errors
  • I have formatted JS and TS files with npm run format-all

@sprrwhwk sprrwhwk temporarily deployed to Preview – carbonmark-api September 28, 2023 18:03 — with GitHub Actions Inactive
@sprrwhwk sprrwhwk marked this pull request as ready for review September 28, 2023 18:03
@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbonmark ✅ Ready (Inspect) Visit Preview Sep 28, 2023 6:06pm
carbonmark-api ✅ Ready (Inspect) Visit Preview Sep 28, 2023 6:06pm
carbonmark-data ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 6:06pm
demo-integration ✅ Ready (Inspect) Visit Preview Sep 28, 2023 6:06pm
klimadao-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 6:06pm
klimadao-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 6:06pm

Copy link
Collaborator

@biwano biwano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On higher screen resolutions the banner does not take the whole space (width). I do not know what we should do. Maybe center the banner?
And it seems to me that the text should be justified. But yet again I am not sure.
I approve and we can let @theprofessora and @jabby09 review

@biwano biwano merged commit 949ec34 into staging Oct 2, 2023
11 checks passed
@biwano biwano deleted the what-is-digital-carbon branch October 2, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[carbon dashboard] Implement the "What is digital carbon" page
2 participants