Simplify profile auth & signature flow #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atmosfearful
requested review from
0xemc,
0xMakka,
biwano,
psparacino and
sprrwhwk
as code owners
Atmosfearful
deployed
to
Preview – carbonmark-api
GitHub Actions
Active
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
biwano
requested changes
Dec 11, 2023
sprrwhwk
reviewed
Dec 11, 2023
0xemc
reviewed
Dec 13, 2023
Atmosfearful
deployed
to
Preview – carbonmark-api
GitHub Actions
Active
|
Oh no... tests pass locally but not remotely... nightmare scenario. Will look deeper tmr |
Atmosfearful
deployed
to
Preview – carbonmark-api
GitHub Actions
Active
Atmosfearful
deployed
to
Preview – carbonmark-api
GitHub Actions
Active
Atmosfearful
changed the title
Atmosfearful
deployed
to
Preview – carbonmark-api
GitHub Actions
Active
Atmosfearful
deployed
to
Preview – carbonmark-api
GitHub Actions
Active
Atmosfearful
deployed
to
Preview – carbonmark-api
GitHub Actions
Active
Atmosfearful
deployed
to
Preview – carbonmark-api
GitHub Actions
Active
Atmosfearful
deployed
to
Preview – carbonmark-api
GitHub Actions
Active
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As we prepare for wallet abstraction (web2 auth) this old JWT verification method should be deprecated.
Switched to a more straightforward signature + nonce approach for every request.
Old way
/verify was used to verify a users signature and mint a JWT for the session
The JWT was included in the edit requests
New way
POST and PUT requests expect an
Authorizationheader which should include a signed message.The string to be signed is included as a vercel env var, and will be shared with the frontend
Note
The frontend needs to be updated to consume v3.0.0 and pass the signature to the header.
QA
User with a nonce:
https://carbonmark-api-git-atmos-simplify-auth-klimadao.vercel.app/users/atmosfearful
User without a nonce (backwards compat)
https://carbonmark-api-git-atmos-simplify-auth-klimadao.vercel.app/users/jabby