[api] Fix listings endpoint for ICR
#2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psparacino
requested review from
Atmosfearful,
0xemc,
0xMakka,
biwano and
sprrwhwk
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
psparacino
changed the title
Token in digital-carbon subgraph
psparacino
changed the title
Token in digital-carbon subgraphlistings endpoint as ICR does not exist as a Token in digital-carbon subgraph
psparacino
changed the title
listings endpoint as ICR does not exist as a Token in digital-carbon subgraphlistings endpoint as ICR does not exist as a Token in digital-carbon subgraph
psparacino
force-pushed
the
fix/listings-endpoint-fetches-ICR-listings
branch
from
5cf8e9d
to
93b9e5c
Compare
psparacino
changed the title
listings endpoint as ICR does not exist as a Token in digital-carbon subgraphlistings endpoint for ICR
psparacino
force-pushed
the
fix/listings-endpoint-fetches-ICR-listings
branch
from
92e632a
to
608d7ce
Compare
sprrwhwk
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes listings endpoint for ICR listings.
The core issue is that the listings endpoint queried the
digital-carbonsubgraph for the token symbol onTokenentity. Currently no ICR tokens are listed in the subgraph asTokens. Ideally, unless ICR token don't qualify asTokens, these should be added so there is no conditional logic in the endpoint.Related Ticket
Closes #2177
Test preview ICR listing
https://carbonmark-api-git-fix-listings-endpoint-fetche-c1b9ef-klimadao.vercel.app/listings/0xe2d23df10da8679d3a0af644a4778d66c7d78c5c9c1540805ae1b3c6bf208e09