Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: migrate utils to ethers v6 and replace BigNumber with bigint #2233

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

sidneyarida
Copy link
Collaborator

@sidneyarida sidneyarida commented Feb 2, 2024

Description

#1425

Migration of utils functions and BigNumber to ether-v6 in carbonmark-api folder

Related Ticket

Closes
Also related to

How to Test

Notes For QA

Specific pages, components or journeys that might be affected:

Relevant preview URLs:

Other notes:

Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbonmark ✅ Ready (Inspect) Visit Preview Feb 8, 2024 11:27am
carbonmark-api ✅ Ready (Inspect) Visit Preview Feb 8, 2024 11:27am
demo-integration ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2024 11:27am
klimadao-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2024 11:27am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
carbon ⬜️ Ignored (Inspect) Visit Preview Feb 8, 2024 11:27am

Copy link
Collaborator

@biwano biwano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR.
Can you just check that logging in still works in carbonmark before merging?
Tests do not cover the verifyProfileSignature function.

@sidneyarida
Copy link
Collaborator Author

I tried the to login and still works

@0xemc
Copy link
Collaborator

0xemc commented Feb 6, 2024

@sidneyarida this is good to go once you resolve the conflicts

# Conflicts:
#	carbonmark-api/package.json
#	carbonmark-api/src/routes/purchases/get.utils.ts
#	carbonmark-api/src/routes/users/[walletOrHandle]/get.ts
#	carbonmark-api/src/utils/helpers/activities.utils.ts
#	carbonmark-api/src/utils/marketplace.utils.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants