Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

‘i2c_config’ has incomplete type struct i2c_config i2c_config; #4409

Closed
outbackdingo opened this issue Jun 19, 2021 · 10 comments
Closed
Labels
not on github Not a topic tracked on github

Comments

@outbackdingo
Copy link

Compiling out/src/i2ccmds.o
src/i2ccmds.c:14:23: error: field ‘i2c_config’ has incomplete type
struct i2c_config i2c_config;

@TheFanatr
Copy link

Why did you close this? I have the same problem; did you find a solution or is this effect due to misuse? If it is the latter, could you please share what you did differently to make it work? Was going to open an issue myself.

@outbackdingo
Copy link
Author

make clean && git pull && make menuconfig again... worked for me.

@outbackdingo outbackdingo reopened this Jun 22, 2021
TheFanatr added a commit to TheFanatr/klipper that referenced this issue Jun 22, 2021
Adds the instruction to run `make clean` after `make menuconfig` if `make` will be run afterwards, otherwise the build will fail as described in the issues below.

Fixes Klipper3d#4409, Klipper3d#3682
@TheFanatr
Copy link

I just PR'd it so that people know what to do until someone fixes the menuconfig script.

@KevinOConnor KevinOConnor added the not on github Not a topic tracked on github label Jun 22, 2021
@github-actions
Copy link

It looks like this ticket is a request for help (or similar). Many helpful people will not see your message here and you are unlikely to get a useful response. Instead, see the contact directions at: https://www.klipper3d.org/Contact.html

We use github to share the results of work done to improve Klipper. We don't use github for requests. (In particular, we don't use github for feature requests, to answer questions, nor to help diagnose problems with a printer.)

Please follow the directions at: https://www.klipper3d.org/Contact.html

This ticket will be automatically closed.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@TheFanatr
Copy link

TheFanatr commented Jun 22, 2021

@KevinOConnor I disagree that this is invalid (unless I'm misunderstanding the reasoning), because the instructions in the installation documentation are incomplete, and as a direct result a lot of beginners have this same issue until they read the comments of #3682 or happen to read the "How to Upgrade" section of the FAQ which has users perform the step described in the aforementioned comments. I should also note that the answer (mentioned in all of the places noted previously), provided by @outbackdingo, is a sufficient workaround but this does not make the issue fixed, or make it not an issue, or instead make it a help request; every user who does not perform a make clean in between make menuconfig and make will have the build fail on them, yet this is exactly what the documentation tells them to do in a vary obvious and visible place. I ask that you reconsider this decision.

@redfox05
Copy link

Just to note, I also came across this during a fresh install on octopi Raspberry Pi 3, which crashed during the make command. Running the clean instructions above allowed things to continue as normal.

@trek-e
Copy link

trek-e commented Jan 2, 2022

Still an issue, just ran into this on my RPI 3 as of Jan 1 2022.

@MattEvansA45
Copy link

As above, I've just encountered this issue following the steps on the main installation page.
image

@TheDopple
Copy link

FWIW, this worked for me:
image

@rsilvers129
Copy link

Had this issue today so it is still not fixed.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
not on github Not a topic tracked on github
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants