Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Creality Ender S1 Config #5689

Closed
wants to merge 1 commit into from
Closed

Update Creality Ender S1 Config #5689

wants to merge 1 commit into from

Conversation

Harrypulvirenti
Copy link

@Harrypulvirenti Harrypulvirenti commented Aug 3, 2022

I found that the provided configuration for the stock Ender 3 S1 is moving the bed outside of the physical limits of the printer.

The result is that the bed is crashing heavily even during a bed mesh calibration.

These changes update the end-stop positions, axis limits and bed mesh points.

The new end-stop positions and limits are targeting the official printing area of 220*220mm

I also added a section for the bed screws position.

These changes update the end-stop positions, axis limits and bed mesh points.
I also added a section for the bed screws position
z_hop_speed: 5
move_to_previous: true
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed to keep the probe to the centre of the bed and, in this way, being able to execute correctly the PROBE_CALIBRATE command

@github-actions
Copy link

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review
    If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@Fisheiyy
Copy link
Contributor

now addressed in #5705

@Fisheiyy
Copy link
Contributor

This can be closed

@Harrypulvirenti
Copy link
Author

@Fisheiyy done.
I hope that next time I will have the possibility to contribute as well 😉

@Fisheiyy Fisheiyy mentioned this pull request Sep 11, 2022
@steti
Copy link

steti commented Dec 22, 2022

It looks like #5689 updates the max temperature for this config, but it does not address the axis limits that were changed here. I can confirm that the position_endstop, position_max, position_min as defined in this file on master cause my Ender 3 S1 to crash when executing the PAUSE macro in Mainsail. That macro attempts to move to the limits defined by printer.toolhead.axis_maximum, minus 5mm in X and Y.

Updating my printer.cfg to the values changed in this PR causes it to stop crashing.

@Fisheiyy
Copy link
Contributor

It looks like #5689 updates the max temperature for this config, but it does not address the axis limits that were changed here. I can confirm that the position_endstop, position_max, position_min as defined in this file on master cause my Ender 3 S1 to crash when executing a PAUSE macro. Updating my printer.cfg to the values changed in this PR causes it to stop crashing.

seems to be a machine to machine problem not a true problem with the config, many things could cause physical differences in locations of endstops, tensioners, and the distance between the v wheels for the bed because of the eccentric nuts

@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants