Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Tina2S printer #6126

Closed
wants to merge 6 commits into from

Conversation

securelyfitz
Copy link

The Tina2S made by Weefun/Weedo is mostly a generic stm32 printer, except for DTR being connected to reset with a resistor instead of with a capacitor circuit. Pyserial holds it low by default, keeping the printer in reset.
The printer works with no code changes if you disassemble it, remove the resistor, and use command restart_method, but as I have several printers I tried to get a software fix working. I modeled it after how the cheetah uses RTS.
I included a config file that has the screen and led working, plus instructions for building and flashing.

@securelyfitz
Copy link
Author

Note: The tina2s is the only klipper printer I have. I haven't tested that my changes don't break other printers

@Deathproof76
Copy link

Hejo, just wanted to say thank you! I'm using your PR, got everything working fully and even my 3dbenchy looks better!

It's my first time using Klipper and also my first 3D-Printer so I'm still figuring everything out. Got just one question: There was a quiet mode setting using the original firmware which most likely used "stealthChop" mode of the TMC2208. I've seen that there are specific TMC2208 configs for the Kipper printer.cfg. Is it possible to enable them with the "as is" pin configuration of the Tina2S? I've looked a bit around in the firmware github but I'm not sure which pin would correspond to the uart-pin, or if I'm completely off in my understanding of the possibilities.

@JamesH1978
Copy link
Collaborator

Thankyou for submitting a PR, please can you refer to https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md paying particular attention to the signed-off-by line.

Also you need to add the regression tests as per point 4 in https://github.com/Klipper3d/klipper/blob/master/docs/Example_Configs.md

Thanks
James

@github-actions
Copy link

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review
    If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@github-actions
Copy link

Unfortunately a reviewer has not assigned themselves to this GitHub Pull Request and it is therefore being closed. It is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@github-actions github-actions bot closed this Apr 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants