Extruder: Allow gaps in extruder numbering.

[viesturz]

When an extruder is not available, IE, it's broken or otherwise, the strict incremental numbering makes it cumbersome to reconfigure the printer.

This allows gaps in the extruder numbering.
The only downside I can see is slight extra work on printer startup. That should amount to <1ms of real life latency.

[Arksine]

This change might break front ends and/or applications connected through the webhooks API. As things stand now it wouldn't be unreasonable for them to make UI decisions based on the assumption that the primary tool will always be named extruder, tool 1 extruder1, etc. I cant say for certain that this is the case, but it is something that likely needs thorough testing.

[viesturz]

True. Fluidd so far seems totally fine with this. But more testing would be useful indeed. This still forces to have a primary extruder named extruder. Only the rest can be arbitrary ordered. This does not break any existing configurations, just allows new configurations that might be incompatible. Do you think this can be incremental process of Klipper relaxing the restriction followed by frontends updating if/when this is an issue?

…

On Sat, Jul 29, 2023, 23:58 Eric Callahan ***@***.***> wrote: This change might break front ends and/or applications connected through the webhooks API. As things stand now it wouldn't be unreasonable for them to make UI decisions based on the assumption that the primary tool will always be named extruder, tool 1 extruder1, etc. I cant say for certain that this is the case, but it is something that likely needs thorough testing. — Reply to this email directly, view it on GitHub <#6302 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMQT4YMLCXBNABWQTIAKGDXSWBOXANCNFSM6AAAAAA24NKSBQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[github-actions]

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review
   If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

[KevinOConnor]

Thanks. As high-level feedback, I'd be leery of making this change for fear of it introducing a regression somewhere. I think it's reasonable to ask users to number their extruders in ascending order.

-Kevin

[github-actions]

Unfortunately a reviewer has not assigned themselves to this GitHub Pull Request and it is therefore being closed. It is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.