Guard against invalid EstimatedSize values

Fixes #394
Klocman · Aug 7, 2022 · 1528c2c · 1528c2c
1 parent eee57a8
commit 1528c2c
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/source/UninstallTools/Factory/RegistryFactory.cs b/source/UninstallTools/Factory/RegistryFactory.cs
@@ -139,8 +139,16 @@ private static ApplicationUninstallerEntry GetBasicInformation(RegistryKey unins
 
         private static FileSize GetEstimatedSize(RegistryKey uninstallerKey)
         {
-            var tempSize = (int)uninstallerKey.GetValue(RegistryNameEstimatedSize, 0);
-            return FileSize.FromKilobytes(tempSize);
+            try
+            {
+                // Use Convert.ToInt64 because some applications put a string in here instead of a number
+                var tempSize = Convert.ToInt64(uninstallerKey.GetValue(RegistryNameEstimatedSize, 0));
+                return FileSize.FromKilobytes(tempSize);
+            }
+            catch (SystemException e) when (e is FormatException or InvalidCastException)
+            {
+                return FileSize.Empty;
+            }
         }
 
         private static Guid GetGuid(RegistryKey uninstallerKey)