Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No debug on stdout #354

Closed
wants to merge 3 commits into from
Closed

Conversation

zbalkan
Copy link
Contributor

@zbalkan zbalkan commented Feb 24, 2022

The library UninsallTools should not contain Console.Write* methods as it should be up to the application using the library. Since those are also used for performance metrics and other debug purposes, I used Debug.Write* methods. Also, I allowed null callback just for a really quiet experience.

@Klocman
Copy link
Owner

Klocman commented May 8, 2022

Thank you for the PR!

  • Instead of converting Console calls to Debug calls, I converted them to Trace calls in c962f01, because using Debug would mean these calls would be removed from the release version. I still want them to be written to the application log for debugging purposes.
  • I skipped the Made callbacks nullable commit to reduce the amount of changes. Instead, I only cherry-picked the Added quiet and unattended cases in QueryApps commit and edited it use an empty lambda instead of a null in b9a8efc.

I'm closing the PR since it's technically merged, but GitHub didn't pick up on it.

@Klocman Klocman closed this May 8, 2022
zbalkan added a commit to zbalkan/Bulk-Crap-Uninstaller that referenced this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants