Renamed nuke to target to be considerate of nuclear attack survivors and their family #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems fine on a glance, please change the PR to ready for review once it's ready for testing. |
|
@Klocman I think it is ready for testing (i.e. I did a scan for any occurances of radioactive and nuke and fixed 'm all up) though do not plan on doing testing myself. Can I still change this to ready for review? |
Yes, if you don't plan to change anything else then you should set it as ready. Draft PRs are generally ignored until they are ready. |
Klocman
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I.e. in response to #367..
.. renamed "nuke" everywhere w. target
.. removed radioactive.png and replaced w. target.png (made w. paint dot net)
I have not ran tests nor tried to compile, I do not have any of the tools installed on my computer.