Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load_strategy parameter on get and get_multi methods #5

Merged
merged 4 commits into from
Jan 16, 2022

Conversation

Kludex
Copy link
Owner

@Kludex Kludex commented Jan 15, 2022

No description provided.

Co-authored-by: Nicolas Chaulet <nicolas.chaulet@gmail.com>
@codecov
Copy link

codecov bot commented Jan 15, 2022

Codecov Report

Merging #5 (c989718) into main (b4e6904) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main        #5   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           65        76   +11     
=========================================
+ Hits            65        76   +11     
Impacted Files Coverage Δ
basesqlmodel/main.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4e6904...c989718. Read the comment docs.

@Kludex
Copy link
Owner Author

Kludex commented Jan 15, 2022

@nicolas-chaulet What do you think about this?

The co-author on the first commit is because it uses your ideas, jfyk.

@nicolas-chaulet
Copy link
Contributor

Yeah I like that! I have been using this syntax for a few days now and it feels quite natural

@Kludex Kludex merged commit 84a5c50 into main Jan 16, 2022
@Kludex Kludex deleted the feature/laod-strategy branch January 16, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants