Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding merging functionality #63

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions lib/knapsack/adapters/base_adapter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,15 @@ def bind
update_report_config

if tracker.config[:generate_report]
Knapsack.logger.info 'Knapsack report generator started!'
bind_time_tracker
bind_report_generator
if tracker.config[:merge_report]
Knapsack.logger.info 'Knapsack report generator started! Will merge results into existing json'
bind_time_tracker
bind_merge_report
else
Knapsack.logger.info 'Knapsack report generator started!'
bind_time_tracker
bind_report_generator
end
elsif tracker.config[:enable_time_offset_warning]
Knapsack.logger.info 'Knapsack time offset warning enabled!'
bind_time_tracker
Expand All @@ -39,6 +45,9 @@ def bind_time_offset_warning
raise NotImplementedError
end

def bind_merge_report
raise NotImplementedError
end
private

def tracker
Expand Down
8 changes: 8 additions & 0 deletions lib/knapsack/adapters/rspec_adapter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,14 @@ def bind_report_generator
end
end

def bind_merge_report
::RSpec.configure do |config|
config.after(:suite) do
Knapsack.report.save_and_merge
Knapsack.logger.info(Presenter.report_details)
end
end
end
def bind_time_offset_warning
::RSpec.configure do |config|
config.after(:suite) do
Expand Down
4 changes: 4 additions & 0 deletions lib/knapsack/config/tracker.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ def time_offset_in_seconds
def generate_report
!!(ENV['KNAPSACK_GENERATE_REPORT'] =~ /\Atrue|0\z/i)
end

def merge_report
!!(ENV['KNAPSACK_MERGE_REPORT'] =~ /\Atrue|0\z/i)
end
end
end
end
Expand Down
14 changes: 14 additions & 0 deletions lib/knapsack/report.rb
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,20 @@ def save
end
end

def save_and_merge
File.open(report_path, 'a+') do |f|
#read in the entire json into a variable, add the new one(s) into the hash, write the result
existing_times = JSON.parse(f.read.delete!("\n")).to_hash #convert file to hash so we can merge in
new_times = JSON.parse(report_json).to_hash unless report_json.nil?

existing_times = existing_times.merge(new_times) unless new_times.nil? || existing_times.nil?
final_copy = JSON.pretty_generate(existing_times)

f.truncate(0) # clear existing content
f.write(final_copy)
end
end

def open
report = File.read(report_path)
JSON.parse(report)
Expand Down
3 changes: 2 additions & 1 deletion lib/knapsack/tracker.rb
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ def default_config
{
enable_time_offset_warning: Config::Tracker.enable_time_offset_warning,
time_offset_in_seconds: Config::Tracker.time_offset_in_seconds,
generate_report: Config::Tracker.generate_report
generate_report: Config::Tracker.generate_report,
merge_report: Config::Tracker.merge_report
}
end

Expand Down
4 changes: 3 additions & 1 deletion spec/knapsack/tracker_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
enable_time_offset_warning: false,
time_offset_in_seconds: 30,
generate_report: true,
merge_report: false,
fake: true
})
end
Expand All @@ -37,7 +38,8 @@
expect(tracker.config).to eql({
enable_time_offset_warning: true,
time_offset_in_seconds: 30,
generate_report: false
generate_report: false,
merge_report: false
})
end
end
Expand Down