Sorting Algorithm: round robin to least connections #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prostko
changed the title
|
TODO: remove > ruby 1.9.3 features |
ArturT
reviewed
Jun 23, 2021
| end | ||
|
|
||
| def sorted_report_with_existing_tests | ||
| @sorted_report_with_existing_tests ||= sorted_report.select { |test_path, time| all_tests.include?(test_path) } | ||
| end | ||
|
|
||
| def total_time_execution | ||
| @total_time_execution ||= sorted_report_with_existing_tests.map(&:last).reduce(0, :+).to_f | ||
| @total_time_execution ||= sorted_report_with_existing_tests.sum { |_test_path, time| time }.to_f |
There was a problem hiding this comment.
I had to change this line because sum method in not available in Ruby <= 2.3 and it was breaking CI build.
Here is the fix 0be9583
ArturT
reviewed
Jun 23, 2021
| y[1] <=> x[1] | ||
| end | ||
| node_tests.map do |node| | ||
| node[:test_files_with_time].sort_by! { |file_name, _time| -file_name } |
There was a problem hiding this comment.
I will keep reverse! 96476a5 because sorting file_name string with - char does not work in Ruby 2.2 https://github.com/KnapsackPro/knapsack/runs/2896841914?check_suite_focus=true
There was a problem hiding this comment.
Using reverse! should not have a big impact on performance and it's more readable than using - char.
https://stackoverflow.com/questions/2642182/how-to-sort-an-array-in-descending-order-in-ruby
|
Thanks @prostko for the PR. I've released knapsack 3.1.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
references #98
Changes the Round Robin approach to a Least Connections approach.
Changes:
.sort.reverses with a sort_by { |x| -x } for readability and terseness:weightkey to default nodes