-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search feature improvement to-dos #4
Comments
Consistently showing "N/A" for non-existing values, table width stably fixed.
Now it will show how many rows are searched with the given multiple conditions and conduct sorting according to the key "_id" at the server side (MongoDB will directly handle it with fast speed)
Now you won't see too horizontally overstretched table due to long text. Now long inner text will be automatically line-broken.
Showing toast message when you trigger searching and receive the data and render on the webpage after receiving data from the database
The user may often receive over 10,000 rows while searching the log data with certain conditions. In this case, pagination won't be useless. However, trying to render every row from the database will be extremely inefficient and even cause lagging on the interface. So, I guess adopting infinite scroll instead of pagination that is clicking-interaction-based would be better for Aesir project. (example: showing the first 300 rows for the first time. If the user scrolls to the end, additional 300 rows will appear, and go on.) |
Be aware that you're using MongoDB while implementing infinite scroll or something similar alternatives in the future. Sort according to For example, the following
|
I changed my thoughts, it'd be better if I just skipped the pagination or infinite scroll feature for now because loading approx. Searching and filtering conditions 10,000 rows (~10MiB) is taken in less than 1 second(kinda acceptable I think). Instead, it'd be better if I show the progress, or just skip this feature for it. |
Concentrating everything on the single JS file isn't a good practice.
Search feature improvements for issue #4
Successfully merged. Closing the issues and may be reopened in the future in case of requiring additional new features related to the search tab. |
Currently, the search tab doesn't provide any kind of pagination. If users search for some conditions in a large-size EVTX dataset collection, the current code will just return lots of rows at once like the picture below. Also, the current status performs sorting via
![image](https://private-user-images.githubusercontent.com/47494005/302039070-4862ed3d-f229-40fa-b6df-60aedcb81b79.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEzMjI4MjIsIm5iZiI6MTcyMTMyMjUyMiwicGF0aCI6Ii80NzQ5NDAwNS8zMDIwMzkwNzAtNDg2MmVkM2QtZjIyOS00MGZhLWI2ZGYtNjBhZWRjYjgxYjc5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE4VDE3MDg0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFhZDQ2ODhhZWI2YWY3MmI2M2Y1YzY3ZTZiYzRjYjZiZDZkODZiMjBiYTYzZGJiMDBmOGZiODVmMTdmNmU0YTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Lf7HIB13lSQF2GT55_r_MgQakqQ-NVJc0FweZj8HJiI)
_id
property after receiving all data from MongoDB, so it might be bad practice in case of large data handlingImprovement suggestions
Pagination (e.g. Showing 30 results at once. Use MongoDB's aggregation to limit the number of results)▶Using infinite scroll?▶ abolished1,920 results
) on the table/webRequestHandler/api.go
Adopting pagination may require additional calculations for querying a specific range of data from MongoDB.
The text was updated successfully, but these errors were encountered: