-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete CONTRIBUTING.md #49
Comments
I think this is part of a larger conversation we need to have in the dev team. How do we want to support external contributors? |
I think we would support external contributors in the same way other open source projects do, they can submit issues and prs, and someone on the team will review, etc. The most important part of this file is to make it easy for new backend team members to get started. |
I don't have a problem with it but I want to get the opinion of other leads. |
I'm not sure if our input is valid in this situation. As long as licensing is open, I think it's up to the maintainer's discretion as to what their contributing file should contain. |
What we decide here should apply to all other open source repos from knighthacks so I think your input is important. |
disagree |
@APherwani contributing.md is for how to contribute to the repo, not who and what and can. It just says how to create/submit issues and prs. |
@TorrentofShame but do you not want to have a conversation on whether we want to allow other people to contribute? |
@APherwani No, nor is this the place for it. |
Fair point |
Let's have this conversation in discord |
@APherwani whats the point of having an open license if we go back and say who can or cannot contribute? The doc is meant for how to contribute. |
I agree but Simon has a point. This is the wrong place to talk about that. Sorry guys this is my fault for starting the conversation here in the first place. |
The
CONTRIBUTING.md
file is currently blank, it should contain information.The text was updated successfully, but these errors were encountered: