Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete CONTRIBUTING.md #49

Open
TorrentofShame opened this issue Sep 19, 2021 · 13 comments
Open

Complete CONTRIBUTING.md #49

TorrentofShame opened this issue Sep 19, 2021 · 13 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@TorrentofShame
Copy link
Contributor

The CONTRIBUTING.md file is currently blank, it should contain information.

@TorrentofShame TorrentofShame added the documentation Improvements or additions to documentation label Sep 19, 2021
@APherwani
Copy link
Contributor

I think this is part of a larger conversation we need to have in the dev team. How do we want to support external contributors?

@TorrentofShame
Copy link
Contributor Author

I think this is part of a larger conversation we need to have in the dev team. How do we want to support external contributors?

I think we would support external contributors in the same way other open source projects do, they can submit issues and prs, and someone on the team will review, etc.

The most important part of this file is to make it easy for new backend team members to get started.

@APherwani
Copy link
Contributor

I don't have a problem with it but I want to get the opinion of other leads.
@aileenpongnon @ElbertTse @AdamPellot @suneettipirneni

@suneettipirneni
Copy link
Member

suneettipirneni commented Oct 11, 2021

I'm not sure if our input is valid in this situation. As long as licensing is open, I think it's up to the maintainer's discretion as to what their contributing file should contain.

@APherwani
Copy link
Contributor

What we decide here should apply to all other open source repos from knighthacks so I think your input is important.

@aileenpongnon
Copy link
Contributor

I don't have a problem with it but I want to get the opinion of other leads. @aileenpongnon @ElbertTse @AdamPellot @suneettipirneni

disagree

@TorrentofShame
Copy link
Contributor Author

@APherwani contributing.md is for how to contribute to the repo, not who and what and can.

It just says how to create/submit issues and prs.

@APherwani
Copy link
Contributor

@TorrentofShame but do you not want to have a conversation on whether we want to allow other people to contribute?
@aileenpongnon any reason you don't agree?

@TorrentofShame
Copy link
Contributor Author

TorrentofShame commented Oct 12, 2021

@APherwani No, nor is this the place for it.

@APherwani
Copy link
Contributor

Fair point

@APherwani
Copy link
Contributor

Let's have this conversation in discord

@ElbertTse
Copy link

@APherwani whats the point of having an open license if we go back and say who can or cannot contribute? The doc is meant for how to contribute.

@APherwani
Copy link
Contributor

I agree but Simon has a point. This is the wrong place to talk about that. Sorry guys this is my fault for starting the conversation here in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

6 participants