Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the way ON key combos work #325

Open
ddevault opened this issue Aug 2, 2015 · 0 comments
Open

Change the way ON key combos work #325

ddevault opened this issue Aug 2, 2015 · 0 comments

Comments

@ddevault
Copy link
Member

ddevault commented Aug 2, 2015

Right now, when you press ON, the kernel will check the pressed keys during the interrupt handler. This is lame for several reasons:

  • Fucks up the keyboard state back in userland if we interrupted a keyboard operation
  • Requires you to press the other bit of the key combo first, which sends a key input to the running program

Alternative idea: press ON, followed by a key. The kernel will stop userland from getting key inputs until you do, and then resume. This gets the keyboard code out of the interrupt, and means you can do meta actions without sending a key to the running program. We can also extend this to userspace, letting them register meta key handlers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant