Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated imp module with importlib #172

Closed
hugovk opened this issue Apr 29, 2023 · 2 comments · Fixed by #184
Closed

Replace deprecated imp module with importlib #172

hugovk opened this issue Apr 29, 2023 · 2 comments · Fixed by #184

Comments

@hugovk
Copy link
Contributor

hugovk commented Apr 29, 2023

This project uses the imp module which has been deprecated since Python 3.4 and set for removal in 3.12:

Python 3.12 is set for release on 2023-10-02 and this library is one of the top 5,000 most-downloaded from PyPI.

Please could you upgrade to use importlib? The imp docs have suggestions on what to use to replace each function and constant.
@hugovk hugovk mentioned this issue May 3, 2023
Open
31 tasks
@mgorny
Copy link
Contributor

mgorny commented Jun 2, 2023

Ping. This is blocking Python 3.12 support on flask-nav.

@mgorny
Copy link
Contributor

mgorny commented Jul 28, 2023

Ping.

@Knio Knio mentioned this issue Oct 23, 2023
Closed
mgorny added a commit to mgorny/dominate that referenced this issue Oct 29, 2023
@mgorny
Modernize setuptools support to use pyproject.toml
b96ae19 
Replace the obsolete `setup.py` script and `setup.cfg` configuration
file with the modern PEP 621 `pyproject.toml` metadata.  This also
implies replacing the custom version/long-description grabbing logic
(that is broken with Python 3.12) with the features nowadays built-in
in setuptools.

Fixes Knio#172
@mgorny mgorny mentioned this issue Oct 29, 2023
Merged
@Knio Knio closed this as completed in #184 Nov 5, 2023
Knio added a commit that referenced this issue Nov 5, 2023
@mgorny @Knio
Modernize setuptools support to use pyproject.toml (#184)
4a66756 
* Modernize setuptools support to use pyproject.toml

Replace the obsolete `setup.py` script and `setup.cfg` configuration
file with the modern PEP 621 `pyproject.toml` metadata.  This also
implies replacing the custom version/long-description grabbing logic
(that is broken with Python 3.12) with the features nowadays built-in
in setuptools.

Fixes #172

Co-authored-by: Tom Flanagan <tom@zkpq.ca>
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Nov 6, 2023
py-dominate: not for Python 3.12
0941b92 
Next version will support it
Knio/dominate#172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modernize setuptools support to use pyproject.toml mgorny/dominate
2 participants
@mgorny @hugovk