Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I have a simple doubt. #617

Closed
Hernandesjunio opened this issue Apr 25, 2016 · 2 comments
Closed

I have a simple doubt. #617

Hernandesjunio opened this issue Apr 25, 2016 · 2 comments
Labels
bug

Comments

@Hernandesjunio
Copy link
Contributor

When I uses ko.validation.utils.isEmptyVal, only return true or undefined. I suggest returns false if not empty.
@crissdev
Copy link
Member

crissdev commented May 8, 2016

@Hernandesjunio indeed, it should return false. Do you want to submit a PR to fix it? Thanks

@Hernandesjunio
Copy link
Contributor Author

Also I identified with some changes as needed to zip code validation using several rules. Tomorrow I will make a contribution to these corrections.

crissdev pushed a commit that referenced this issue Jun 17, 2016
@Hernandesjunio @crissdev
Fix #617 - isEmptyVal doesn't always return a boolean
50a5c98 
Closes #620
@crissdev crissdev added the bug label Jun 26, 2016
crissdev pushed a commit that referenced this issue Aug 22, 2018
@Hernandesjunio @crissdev
Fix #617 - isEmptyVal doesn't always return a boolean
58e42a4 
Closes #620
crissdev pushed a commit that referenced this issue Oct 5, 2019
@Hernandesjunio @crissdev
Fix #617 - isEmptyVal doesn't always return a boolean
70d6cfc 
Closes #620
crissdev pushed a commit that referenced this issue Oct 5, 2019
@Hernandesjunio @crissdev
Fix #617 - isEmptyVal doesn't always return a boolean
06ed678 
Closes #620
@crissdev crissdev mentioned this issue Oct 8, 2019
Merged
crissdev pushed a commit that referenced this issue Oct 9, 2019
@Hernandesjunio @crissdev
Fix #617 - isEmptyVal doesn't always return a boolean
411ed1c 
Closes #620
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crissdev @Hernandesjunio