Inefficent Queries (get/filter) Don't Return Results In Some Cases #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nasty bug here where for inefficient queries the limit on the query wasn't being reset. Somewhere in the get/filter django sets a limit to 21 (I think this is MAX_GET_RESULTS +1; use grep to find if curious). When there were more than 21 results in the query set there was a good chance that the result that matches the provided filter would not be in the result set.
sethdenner
force-pushed
the
fix-inefficient-queries-cant-find-results
branch
from
87fe727
to
0366b87
Compare
sethdenner
added a commit
that referenced
this pull request
Oct 29, 2015
…ind-results Inefficent Queries (get/filter) Don't Return Results In Some Cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nasty bug here where for inefficient queries the limit on the query wasn't being reset. Somewhere in the get/filter django sets a limit to 21 (I think this is MAX_GET_RESULTS +1; use grep to find if curious). When there were more than 21 results in the query set there was a good chance that the result that matches the provided filter would not be in the result set.