add new Activatable trait #214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| namespace Knp\DoctrineBehaviors\Model\Activable; | ||
|
|
||
|
|
|
Well, I am -1 for this PR.
|
| @@ -154,3 +156,13 @@ services: | |||
| tags: | |||
| - { name: doctrine.event_subscriber } | |||
|
|
|||
|
|
|||
akovalyov
force-pushed
the
master
branch
4 times, most recently
from
6cb1e53
to
0a444f6
Compare
flug
force-pushed
the
activable
branch
4 times, most recently
from
24c0ba9
to
a1cd487
Compare
|
not sure we should add too much new features, sorry. |
|
Seems there is no consensus to add this new feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.