Encode CopySource parameter for rename in Aws

Update AwsS3Test.php
KnpLabs · Jan 7, 2020 · 3b1b8e8 · 3b1b8e8
1 parent d17a2e3
commit 3b1b8e8
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/Gaufrette/Adapter/AwsS3.php b/src/Gaufrette/Adapter/AwsS3.php
@@ -134,7 +134,7 @@ public function rename($sourceKey, $targetKey)
         $this->ensureBucketExists();
         $options = $this->getOptions(
             $targetKey,
-            ['CopySource' => $this->bucket . '/' . $this->computePath($sourceKey)]
+            ['CopySource' => urlencode($this->bucket . '/' . $this->computePath($sourceKey))]
         );
 
         try {

diff --git a/tests/Gaufrette/Functional/Adapter/AwsS3Test.php b/tests/Gaufrette/Functional/Adapter/AwsS3Test.php
@@ -188,4 +188,16 @@ public function shouldUploadWithGivenContentType()
 
         $this->assertEquals('text/html', $this->filesystem->mimeType('foo'));
     }
+
+    /**
+     * @test
+     */
+    public function shouldRenameAnObject()
+    {
+        $this->filesystem->write('foo', '');
+        $this->filesystem->rename('foo', 'foo%_encode');
+
+        $this->assertFalse($this->filesystem->has('foo'));
+        $this->assertTrue($this->filesystem->has('foo%_encode'));
+    }
 }